Avoid reborrow errors in Array methods#23197
Open
SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Open
Avoid reborrow errors in Array methods#23197SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
SuchAFuriousDeath wants to merge 2 commits intoruffle-rs:masterfrom
Conversation
Lord-McSweeney
added
A-avm2
SuchAFuriousDeath
force-pushed
the
array-reentrancy
branch
2 times, most recently
from
9af3c05 to
8b2f45b
Compare
SuchAFuriousDeath
force-pushed
the
array-reentrancy
branch
from
8b2f45b to
992f70f
Compare
|
|
||
| trace(""); | ||
|
|
||
| // Test indexOf reborrows during hole resolution |
Collaborator
There was a problem hiding this comment.
How could these two test cases (indexOf and lastIndexOf) cause a reborrow?
| array_storage.set(i, resolve_array_hole(activation, this, i, item)?); | ||
| let item = array_object.storage().get(i); | ||
| let resolved = resolve_array_hole(activation, this, i, item)?; | ||
| array_object.storage_mut(activation.gc()).set(i, resolved); |
Collaborator
There was a problem hiding this comment.
This is going to hurt splice performance- I think @kjarosh was trying to improve it in the past? Is this really the fastest we can do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21929
Fixes #22922
Fixes #22330
Fixes #22377
I wasn't able to to reproduce, but based on the stack traces and line numbers, all of them should be fixed.