avm1: Make XmlSocket.connect(null) behave like connect()#23000
Open
adrian17 wants to merge 1 commit intoruffle-rs:masterfrom
Open
avm1: Make XmlSocket.connect(null) behave like connect()#23000adrian17 wants to merge 1 commit intoruffle-rs:masterfrom
adrian17 wants to merge 1 commit intoruffle-rs:masterfrom
Conversation
Member
|
Can we add a test for it? |
kjarosh
added
A-avm1
Contributor
|
Does this also fix when Edit: Assuming yes because of the line: |
Collaborator
Author
I don't really know how to :c |
Collaborator
Author
|
@kjarosh do you consider the lack of a test to be blocking? |
Member
|
Sorry about the delay, I planned to take a look and craft a simple test. Not having a test can introduce regressions in the future, I don't think it's blocking though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22995 .
Also added logging to a failure case (avm2 implementation has the same logging), but didn't change the behavior.