Add access property to 'using' CppVariable#71
Merged
virtuald merged 2 commits intorobotpy:mainfrom Aug 7, 2021
Merged
Conversation
Member
|
Seems like a reasonable change. Could you please add a test for this? |
Contributor
Author
|
Done, I kind of hijacked another test case, I have no problem if you prefer a specific test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
properties, typedefs, etc. are stored in a dict where the key is the access specifier. But for
using, the key is the variable name.Unless I missed it, for
usingthere is currently no way to get the access specifier... so this PR intends to add it.