Makes acceptance test more stable with Travis#756
Merged
aaltat merged 3 commits intorobotframework:masterfrom Feb 8, 2017
aaltat:make_acceptance_test_more_stable
Merged
Makes acceptance test more stable with Travis#756aaltat merged 3 commits intorobotframework:masterfrom aaltat:make_acceptance_test_more_stable
aaltat merged 3 commits intorobotframework:masterfrom
aaltat:make_acceptance_test_more_stable
Conversation
There is quite often a random failures with test that open new window. It seem that with Travis is takes little bit of time to open a window and this fix wait the windows to open before test is performed. Partially fixes #734
pekkaklarck
reviewed
Feb 7, 2017
| Wait Untill Window Is Open | ||
| ${titles} = Get Window Titles | ||
| ${status} = Evaluate len(${titles}) > 1 | ||
| Should Be True ${status} |
Member
There was a problem hiding this comment.
Wait Until Window Is Open sounds like a keyword that could be in the library itself. Also, there's only one L in Until.
Contributor
Author
|
There has been some complaints from users too, example #750 and we should build such I will fix the typo later today. |
Contributor
Author
|
Created #757 to create the new keyword |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is quite often a random failures with test that open new window.
It seem that with Travis is takes little bit of time to open a window
and this fix wait the windows to open before test is performed.
Partially fixes #734