Remove remote driver server exception#1806
Merged
emanlove merged 4 commits intorobotframework:masterfrom Dec 28, 2022
Merged
Conversation
In a few unit test cases we were using a generic exception for testing the webdriver cache. That exception was depreciated and I replaced it with another.
There is a failing test, `multiple_browsers_executable_path.Chrome Browser With executable_path Argument`, that is failing due to a recent change/addition by the Selenium project to have a driver manager which, apparently, is correcting for this incorrect path to driver test. As there are several factors in play at this time I am kicking this test down the road.
Merged
Brownies
approved these changes
Dec 28, 2022
| @@ -10,7 +10,7 @@ Documentation Creating test which would work on all browser is not possible. | |||
|
|
|||
| *** Test Cases *** | |||
| Chrome Browser With executable_path Argument | |||
Member
There was a problem hiding this comment.
Might as well remove the whole test, as of version 4.6 Selenium will inject their own webdriver for Chrome/Firefox/Edge if one isn't already installed: https://www.selenium.dev/blog/2022/introducing-selenium-manager/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.