Remove deprecated rebot option#1793
Conversation
| options.extend([opt.format(browser=browser) for opt in ROBOT_OPTIONS]) | ||
| if rf_options: | ||
| options += rf_options | ||
| options += ["--exclude", f"known issue {browser.replace('headless', '')}"] |
There was a problem hiding this comment.
Do you think this is fine or should this be done the same way as browser is inserted into ROBOT_OPTIONS?
There was a problem hiding this comment.
I don't think we can assume it would be headless. Instead I would treat headless as separate. As I write this I was hoping that I could get some ease to having to write both Known Issue Chrome and Known Issue Headless Chrome each and every time. But realized this is the same assuming that a chrome issue affect both headed and headless.
Would a method be that if it affect only a headed or headless operation of the browser to say Known Issue Chrome headless only? Can we post process this with the current toolset or is this a bit more work?
There was a problem hiding this comment.
@Brownies Would you want to separate this question of known issues from the critical fix? Not saying you have to but I was assuming that the non critical is what is failing the test against Robot Framework version > 5.0. If it is then separating this might allow us to resolve that and check newer RF versions while working through this question of known issues. Just a thought and open to differing opinions on this.
There was a problem hiding this comment.
I'm quite sure handling headed and headless issues separately with a single tag will require some more effort.
I don't really want to separate this from the --noncritical fix because this is a replacement for that functionality. I can remove it if you really want to but it will cause tests with known issues to be executed unless users manually --exclude them. This wouldn't break Github actions though because all tests should pass with Chrome.
There was a problem hiding this comment.
I may have understood this wrong. I will relook at it sometime over the next few days.
| "--outputdir", | ||
| RESULTS_DIR, | ||
| "--noncritical", | ||
| "known issue {browser}", |
There was a problem hiding this comment.
There are more "Known Issue" tags beyond just chrome in these tests so I don't think known issue {browser} should be removed.
In addition the question of headless versus headed is a good one I'll address in the other change.
There was a problem hiding this comment.
I don't quite understand why you would not want to remove this bit.
--noncritical is an option that takes a tag argument and known issue {browser} is the argument. If it is left there rebot will interpret it as the input file.
| options.extend([opt.format(browser=browser) for opt in ROBOT_OPTIONS]) | ||
| if rf_options: | ||
| options += rf_options | ||
| options += ["--exclude", f"known issue {browser.replace('headless', '')}"] |
There was a problem hiding this comment.
I don't think we can assume it would be headless. Instead I would treat headless as separate. As I write this I was hoping that I could get some ease to having to write both Known Issue Chrome and Known Issue Headless Chrome each and every time. But realized this is the same assuming that a chrome issue affect both headed and headless.
Would a method be that if it affect only a headed or headless operation of the browser to say Known Issue Chrome headless only? Can we post process this with the current toolset or is this a bit more work?
| options.extend([opt.format(browser=browser) for opt in ROBOT_OPTIONS]) | ||
| if rf_options: | ||
| options += rf_options | ||
| options += ["--exclude", f"known issue {browser.replace('headless', '')}"] |
There was a problem hiding this comment.
@Brownies Would you want to separate this question of known issues from the critical fix? Not saying you have to but I was assuming that the non critical is what is failing the test against Robot Framework version > 5.0. If it is then separating this might allow us to resolve that and check newer RF versions while working through this question of known issues. Just a thought and open to differing opinions on this.
emanlove
added
deprecation
priority: low
acknowledge
3 participants
Fixes #1788
Also updates
checkoutaction tov3andsetup-pythonaction tov4.Actions based on Node12 now emit warnings like
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/setup-python, actions/setup-python, actions/checkout