Conversation
Sync the base
…ete filter_section_by_tags function
…d on include/exclude tags
Sync from upstream
- Introduced the TextEntry model with support for content and optional tags. - Added tests for TextEntry to validate creation, required fields, and tag handling. - Updated existing tests to accommodate the new TextEntry model. - Implemented comprehensive tests for the filter module, ensuring correct behavior for include/exclude logic. - Added tests for the Version model to validate include/exclude tag functionality. - Enhanced test coverage for filtering RenderCV models by version, ensuring original models remain unchanged.
…ing and readability
…chema descriptions for highlights
Tags in the sections
fix: correct exclude tag in Version model and tests
…r dict representations
feat: enhance version description and improve highlight processing fo…
|
@sinaatalay Please share your feed back regarding this implementation. |
|
Thank you for your contribution. I will review it as soon as possible. |
|
Thank you, but I think this feature makes the schema too complicated. While it adds the functionality, it also makes the schema and editor suggestions much more complex, even for users who won’t use this feature. Also, what do you think about having AI handle all of this for you in a new file with a single prompt? If we want this feature, we need to come up with a strong UX design that doesn’t make the schema significantly more complicated. This approach also introduces rendering concerns into the schema and validation. Currently, the schema doesn’t consider the rendering side at all. |
|
I think we should gather more feedback. To me this feature should follow opt-out approach. the default schema should suggest the existing flow. Everything in this feature can be made optional. |
cff31ca to
2b08030
Compare
|
FWIW I love this idea. |
Overview
This PR introduces a tag based CV filtering system that allows you to generate different versions of you CV from a single YAML file. I came up with this solution to solve a specific need of mine: tailor different CV for specific audiences (like academic, backend, devops) without maintaining multiple files or worse! multiple git branches.
Key features
Tags on entry types
tagsfield.TextEntrytype for tagged text entries.Tags on highlights
Individual entries in the highlights can now have tags allowing granular control.
Version definitions
Now, you can define versions with
includeand/orexcludetag filtersPermissive filtering
How to use
Filtering logic
Backward Compatibility
This feature is fully backward compatible:
tagsare always included--versionflag is optionalFixes: #164