feat(locale): Added Norwegian (Bokmål and Nynorsk) locale#652
feat(locale): Added Norwegian (Bokmål and Nynorsk) locale#652sinaatalay merged 2 commits intorendercv:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for two official Norwegian writing standards: Norwegian Bokmål and Norwegian Nynorsk. The implementation follows the established pattern for adding new locales to RenderCV by creating YAML configuration files that are auto-discovered and dynamically converted to Pydantic models.
Changes:
- Added Norwegian Nynorsk locale with appropriate translations for month names, date formatting, and time-related text
- Added Norwegian Bokmål locale with appropriate translations (file exists but not shown in diff)
- Updated ISO 639-1 language code mappings to include 'nb' for Bokmål and 'nn' for Nynorsk
- Regenerated schema.json to include the new locale definitions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rendercv/schema/models/locale/other_locales/norwegian_nynorsk.yaml | Defines Norwegian Nynorsk locale with translations for UI text and month names |
| src/rendercv/schema/models/locale/english_locale.py | Adds ISO 639-1 codes 'nb' and 'nn' to the language_iso_639_1 mapping dictionary |
| schema.json | Auto-generated schema file updated with Norwegian locale definitions and discriminated union mappings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you! I pushed a small fixup commit with the following corrections: the Nynorsk |
Added the two official writing standards for Norwegian: Norwegian Bokmål and Norwegian Nynorsk. Updated `english_locale-py` with the ISO 639-1 codes of 'nb' and 'nn'.
sinaatalay
force-pushed
the
feat/norwegian-locale
branch
from
77c6b0e to
c9f4e2d
Compare
- Fix Nynorsk "present" translation: "noverande" → "nåverande" - Regenerate schema.json via update_schema.py instead of manual edits - Add missing trailing newlines to both YAML files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sinaatalay
force-pushed
the
feat/norwegian-locale
branch
from
c9f4e2d to
baa28be
Compare
|
Nice 👍
Ah, that makes sense. I think I just used another PR as an example, and saw that Thanks for the fixes! |
* feat(locale): Added Norwegian (Bokmål and Nynorsk) locale Added the two official writing standards for Norwegian: Norwegian Bokmål and Norwegian Nynorsk. Updated `english_locale-py` with the ISO 639-1 codes of 'nb' and 'nn'. * Fix Nynorsk typo, regenerate schema, and add trailing newlines - Fix Nynorsk "present" translation: "noverande" → "nåverande" - Regenerate schema.json via update_schema.py instead of manual edits - Add missing trailing newlines to both YAML files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Sina Atalay <79940989+sinaatalay@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Added the two official writing standards for Norwegian: Norwegian Bokmål and Norwegian Nynorsk.
Updated
english_locale-pywith the ISO 639-1 codes of 'nb' (for Bokmål) and 'nn' (for Nynorsk).