feat: allow list of strings for headline and custom headline separator#635
feat: allow list of strings for headline and custom headline separator#635aasim-m wants to merge 3 commits intorendercv:mainfrom
Conversation
|
Tests pass locally on Windows with |
|
Yes, you need to commit the updated testdata, as described here: I won’t be available to work on RenderCV for a while, but I’ll review this as soon as I’m back. |
|
Tests are passing now. I re-ran |
|
Can you please explain in more detail how this feature is useful and how it appears in the PDF? It increases the complexity of the schema, so I want to make sure we really need it. |
sinaatalay
force-pushed
the
main
branch
3 times, most recently
from
cff31ca to
2b08030
Compare
2 participants
Types of Changes
Description
This PR improves the flexible configuration of the CV headline by adding:
cv.headline(e.g.,["Role A", "Role B"]) instead of just a single string.design.header.headline_separator(defaulting to—) to allow customization of how the headline items are joined.Technical Details
CVmodel insrc/rendercv/schema/models/cv/cv.pyto allowlist[str]forheadline.headline_separatorto theHeadermodel insrc/rendercv/schema/models/design/classic_theme.py.src/rendercv/renderer/templater/model_processor.pyto correctly apply string processors to individual items whenheadlineis a list.src/rendercv/renderer/templater/templates/typst/Header.j2.typ) and Markdown (src/rendercv/renderer/templater/templates/markdown/Header.j2.md) templates to join these items using the configured separator.