Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new FILENAME placeholder that can be used in output file path configurations. The placeholder resolves to the input YAML filename (without extension) with spaces replaced by hyphens, enabling users to differentiate output files when multiple CV YAML files with the same content but different filenames exist in the same directory.
- Adds
FILENAMEplaceholder to the path resolver that extracts the stem of the input YAML file - Updates documentation across schema, user guide, and code comments
- Includes test coverage for the new placeholder functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rendercv/renderer/path_resolver.py | Implements the FILENAME placeholder by extracting the input file path stem and replacing spaces with hyphens |
| src/rendercv/schema/models/settings/render_command.py | Documents the FILENAME placeholder in the file path placeholders description |
| tests/renderer/test_path_resolver.py | Adds a test case verifying FILENAME placeholder resolves correctly with space-to-hyphen conversion |
| schema.json | Updates JSON schema descriptions for all output path fields (typst_path, pdf_path, markdown_path, html_path, png_path) to include FILENAME placeholder |
| docs/user_guide/yaml_input_structure/settings.md | Adds FILENAME to the list of available placeholders in the user guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you. It looks like tests fail. |
sinaatalay
force-pushed
the
main
branch
3 times, most recently
from
cff31ca to
2b08030
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add FILENAME placeholder while creating the output file.
Helps when there are multiple CV files in same folder and each with same name and details but different filenames for different purposes.