feat: Add Arabic locale support and update Typst preamble template.#591
Merged
sinaatalay merged 11 commits intorendercv:mainfrom Feb 17, 2026
Merged
feat: Add Arabic locale support and update Typst preamble template.#591sinaatalay merged 11 commits intorendercv:mainfrom
sinaatalay merged 11 commits intorendercv:mainfrom
Conversation
Member
|
This is great. I think test data needs to be updated for tests to pass. I explained that in developer guide here: Testing. I'll review this and rendercv/rendercv-typst#2 as soon as possible. |
Contributor
Author
|
I fixed the html and md problem now the update works complety with RTL languages and Arabic is fully supported. In addition new variable cv_title_name in locale is added so it can be changed in the html/md output. still the testes need to be fixed and the rendercv/rendercv-typst#2 need to be released so the update can work. |
Contributor
Author
|
@sinaatalay I added the required tests, but still this code needs the next release of rendercv/rendercv-typst#2 to make the the needed imports correct |
… changeable to support different languages.
Member
|
Thanks a lot! |
yafei-ou
pushed a commit
to yafei-ou/rendercv
that referenced
this pull request
Feb 27, 2026
* feat: Add Arabic locale support and update Typst preamble template. * feat: add rtl support for the Full.html template * fix: change "'s CV" hardcoded word in the html/md outputs and make it changeable to support different languages. * test: add tests for RTL support * test: add tests for RTL support * Improve implementation * Update testdata * Fix merge issues * Simplify * Add test and use type hints with type adapters * Fix `just check` errors --------- Co-authored-by: Khalid <khalid.pro.968@gmail.com> Co-authored-by: Sina Atalay <79940989+sinaatalay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Related to #452)
Added Arabic as valid locale.
There are still quite a few RTL issues.
PDF and PNG:
Works fine Sections' headers and contents are rendered correctly and aligned to the right:
HTML and MD:
The rendered html is missing . Can be manually added by the user but would be nice if could be done automatically.
This code requires the latest changes of rendercv-typst rendercv/rendercv-typst#2