feat(locale): add Hebrew locale (and generic RTL issues)#587
Draft
DeepSpace2 wants to merge 1 commit intorendercv:mainfrom
Draft
feat(locale): add Hebrew locale (and generic RTL issues)#587DeepSpace2 wants to merge 1 commit intorendercv:mainfrom
DeepSpace2 wants to merge 1 commit intorendercv:mainfrom
Conversation
DeepSpace2
changed the title
Member
|
Thank you! See #591 and rendercv/rendercv-typst#3 |
Author
|
Nice, so apparently the PDF RTL issue is solved by #591 and rendercv/rendercv-typst#3. I can wait for these to be merged and verify against my branch. As for the HTML, I'll need to look a bit deeper as it doesn't look like it is handled by #591. Again, I'll wait for it to be merged as I need access to the added properties in https://github.com/rendercv/rendercv/blob/main/src/rendercv/renderer/html.py |
|
Hi @sinaatalay |
Member
Yes @anefzaoui , support for right-to-left languages is coming very soon in v2.7. |
sinaatalay
force-pushed
the
main
branch
3 times, most recently
from
cff31ca to
2b08030
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Related to #452 and blocked by #591)
Added Hebrew as a valid locale. Also took the liberty to update line numbers in the docs.
There are still quite a few RTL issues.
PDF:
HTML:
<body dir="rtl">. Can be manually added by the user but would be nice if could be done automatically. The fix for this might required adding a new "rtl" boolean to locale in the schema/model.There are possibly more issues that I haven't found or noticed yet.
As the fixes would probably be required to render other RTL languages we can use this PR as a larger initiative.
This feels like a regression from 2.3, as the CV is rendered perfectly on the web app by simply using