X Tutup
Skip to content

Search and replace 'parial' with 'partial'.#380

Merged
sinaatalay merged 2 commits intorendercv:mainfrom
thomascamminady:main
Oct 22, 2025
Merged

Search and replace 'parial' with 'partial'.#380
sinaatalay merged 2 commits intorendercv:mainfrom
thomascamminady:main

Conversation

@thomascamminady
Copy link
Contributor

Should address #362

@amarvin amarvin mentioned this pull request Mar 27, 2025
@ShoGinn
Copy link

ShoGinn commented Apr 20, 2025

Should address #362

I disagree.

This will not address #362 as this is just to fix the variables for error messages.

@thomascamminady
Copy link
Contributor Author

thomascamminady commented Apr 20, 2025

Thanks for having a closer look and sorry for the false assumption on my end. Shall I rename the PR to something more appropriate and leave it with fixing this typo in this PR?

@ShoGinn
Copy link

ShoGinn commented Apr 21, 2025

Thanks for having a closer look and sorry for the false assumption on my end. Shall I rename the PR to something more appropriate and leave it with fixing this typo in this PR?

Certainly; I have discovered that being more direct with language facilitates easier comprehension.

This remains a valid issue, and the misspellings should be corrected!

The absence of a fix in #362 is attributed to the fact that no version has been released since issue #349.

@sinaatalay
Copy link
Member

Thank you.

@sinaatalay sinaatalay merged commit 21f96a5 into rendercv:main Oct 22, 2025
13 checks passed
IanHollow pushed a commit to IanHollow/rendercv that referenced this pull request Oct 22, 2025
Co-authored-by: Sina Atalay <79940989+sinaatalay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup