Do not make bold sub words and ignore case#348
Merged
sinaatalay merged 1 commit intorendercv:mainfrom Feb 9, 2025
abassel:fix/fix_bold_words
Merged
Do not make bold sub words and ignore case#348sinaatalay merged 1 commit intorendercv:mainfrom abassel:fix/fix_bold_words
sinaatalay merged 1 commit intorendercv:mainfrom
abassel:fix/fix_bold_words
Conversation
Member
|
Thank you! Your code for |
Contributor
Author
|
Glad to help. Just added the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all: Thank you for sharing this wonderful project with us. It helped me a lot to automate my resume during my job search.
I came across few bolding issues few days ago and fixed them in my local machine but before I could open the PR I noticed you fixed part of them. This PRs is fixing the issues where occurrences of subword gets bold. Lets say I want to bold java and I get the java part of javascript bold. Also it supports different case(AWS vs Aws vs aws)The fix uses regular expressions to have a more robust bold. Additionally I added doctests but I only could run them if I changed the imports like below:
Then test by executing the command:
python3 -m doctest -f rendercv/data/models/entry_types.py -vI did not add the import change to the commit since imports can get tricky.
The final output should be:
ps: the diff for the other code that you just fixed is below. I don't think it is needed but just putting it here to register a different solution:
Thank you!