netiquette - Prevent new issue link if disabled#9028
Open
dnicolson wants to merge 1 commit intorefined-github:mainfrom
Open
netiquette - Prevent new issue link if disabled#9028dnicolson wants to merge 1 commit intorefined-github:mainfrom
netiquette - Prevent new issue link if disabled#9028dnicolson wants to merge 1 commit intorefined-github:mainfrom
Conversation
|
|
||
| export function getResolvedText(closingDate: Date): JSX.Element { | ||
| const ago = <strong>{twas(closingDate.getTime())}</strong>; | ||
| const canOpenNewIssue = elementExists('li:has([data-content="Issues"])'); |
Member
There was a problem hiding this comment.
same refined-github/github-url-detection#240 (review)
solution is similar too
Member
|
In such cases, it might be better not to display the banner at all. What do you think @fregante? |
Member
|
Yes 👆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the new issue link from being displayed if issues are disabled.
rgh-netiquetteis similarly affected, but the copy isn't as easily updated.Test URLs
palera1n/loader#66
Screenshot