X Tutup
Skip to content

warning-for-disallow-edits - Restore on compare pages#9007

Merged
SunsetTechuila merged 9 commits intorefined-github:mainfrom
dnicolson:patch-1
Mar 2, 2026
Merged

warning-for-disallow-edits - Restore on compare pages#9007
SunsetTechuila merged 9 commits intorefined-github:mainfrom
dnicolson:patch-1

Conversation

@dnicolson
Copy link
Contributor

@dnicolson dnicolson commented Feb 23, 2026 •
edited by SunsetTechuila
Loading

Fixes:

errors.js:77 ❌ Refined GitHub: warning-for-disallow-edits
errors.js:78 📕 26.2.19 → Error: Element not found
    at attachElement (attach-element.js:13:9)
    at init (warning-for-disallow-edits.js:19:2)
    at feature-manager.js:197:26
    at async-for-each.js:6:52
    at Array.map (<anonymous>)
    at asyncForEach (async-for-each.js:6:34)
    at feature-manager.js:196:9
    at async Promise.all (index 0)
    at async asyncForEach (async-for-each.js:6:2)

Test URLs

https://github.com/<owner>/<repo>/compare/main...<user>:<repo>:<branch>

Screenshot

image

@SunsetTechuila

This comment was marked as outdated.

Sign in to view
@SunsetTechuila

This comment was marked as outdated.

Sign in to view
@fregante fregante added the bug label Feb 24, 2026
@SunsetTechuila SunsetTechuila changed the title warning-for-disallow-edits - Fix element not found warning-for-disallow-edits - Restore on compare pages Feb 25, 2026
SunsetTechuila
SunsetTechuila reviewed Feb 25, 2026
View reviewed changes
source/features/warning-for-disallow-edits.tsx
Comment on lines +30 to +34
// Prevent layout shifting when warning appears
option.classList.remove('flex-auto');
const actionRow = option.parentElement!;
actionRow.classList.add('mt-1');
actionRow.parentElement!.classList.remove('flex-wrap');
Copy link
Member

@SunsetTechuila SunsetTechuila Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGH:

Image

RGH without these class changes:

Image

No RGH:

Image

This comment was marked as resolved.

Sign in to view

Copy link
Member

@SunsetTechuila SunsetTechuila Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGH with this feature disabled:

msedge_RPSV4oUOs9

@fregante
Copy link
Member

fregante commented Mar 1, 2026

:shipit:

@SunsetTechuila SunsetTechuila merged commit 425970d into refined-github:main Mar 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SunsetTechuila SunsetTechuila SunsetTechuila approved these changes

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnicolson @SunsetTechuila @fregante
X Tutup