jump-to-conversation-close-event - Restore on long issues#8892
jump-to-conversation-close-event - Restore on long issues#8892SunsetTechuila merged 17 commits intorefined-github:mainfrom
jump-to-conversation-close-event - Restore on long issues#8892Conversation
SunsetTechuila
changed the title
github-actions
bot
changed the title
jump-to-conversation-close-event - Restore feature on long issues
SunsetTechuila
changed the title
jump-to-conversation-close-event - Restore feature on long issuesjump-to-conversation-close-event - Restore on long issues
|
I'm going to force push this to clean-up the commit history |
SunsetTechuila
force-pushed
the
jump-to-close
branch
from
b7eacd4 to
8ea1723
Compare
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Can be merged after the 2 changes
This comment was marked as outdated.
This comment was marked as outdated.
| />, | ||
| ); | ||
| for (const statusBadge of statusBadges) { | ||
| const maybeWrapper = statusBadge.parentElement!; |
There was a problem hiding this comment.
| const maybeWrapper = statusBadge.parentElement!; | |
| const maybeWrapper = statusBadge.parentElement as HTMLAnchorElement |
! and as are both assertions, no need to use both
There was a problem hiding this comment.
We can't be sure that it is HTMLAnchorElement until we check the class
There was a problem hiding this comment.
I just dislike this block, but I can’t think of anything better. I guess it’s not worth caring about so much
There was a problem hiding this comment.
Yes but it doesn't really matter, we only use it as an anchor. I'm not a fan of (obj as T).prop inline assertions, same as https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-await-expression-member.md but for assertions
2 participants
addresses #8296 (comment)
depends on #8891
Test URLs
#4166
Screenshot