Fix feature loading on soft navigation between React-based pages by SunsetTechuila · Pull Request #8881 · refined-github/refined-github

SunsetTechuila · 2026-01-20T13:53:06Z

partially _fixes #6554

Test URLs

Screenshot

package.json

This reverts commit 6880958.

fregante · 2026-01-22T10:02:32Z

 one-event 4.4.0 published 🎉

source/features/linkify-text.tsx

SunsetTechuila · 2026-01-22T10:22:38Z

source/feature-manager.tsx

 				}
 			});
-		} while (await oneEvent(document, 'turbo:render'));
+		} while (await oneEvent(document, ['turbo:render', 'soft-nav:react-done']));


unlike soft-nav:render, soft-nav:react-done is fired when user navigates the session history too

SunsetTechuila · 2026-01-27T17:20:06Z

source/feature-manager.tsx

 	document.addEventListener('turbo:before-fetch-request', unloadAll); // Clicks
 	document.addEventListener('turbo:visit', unloadAll); // Back/forward button
-	document.addEventListener('soft-nav:progress-bar:start', unloadAll); // Soft navigation
+	document.addEventListener('soft-nav:start', unloadAll); // Soft navigation


This is a bit too early, but other events are fired too late

fregante · 2026-01-28T08:10:10Z

source/feature-manager.tsx

+	document.addEventListener('soft-nav:start', unloadAll); // Soft navigation
+	addEventListener('popstate', unloadAll); // History navigation


Do you reckon that we can proceed without these two early events or do they cause too much trouble/noise in the console?

What does "firing too early" mean? Does the page break visually?

What does "firing too early" mean? Does the page break visually?

Here is a demonstration:

refined-github/source/features/rgh-feature-descriptions.tsx

Lines 150 to 152 in 815661e

signal.addEventListener('abort', () => {

descriptionBanner.remove();

});

refined-github/source/features/rgh-feature-descriptions.tsx

Lines 157 to 159 in 815661e

signal.addEventListener('abort', () => {

disabledBanner.remove();

});

Now I think why not unload on soft-nav:render? Seems to work well

Do you reckon that we can proceed without these two early events

We can't. Neither the turbo:before-fetch-request nor the turbo:visit events are fired in the test cases I provided in the PR description

Now I think why not unload on soft-nav:render?

I've let this idea marinate in my head, and I think it's too risky

To see the issue or test the fix: 1. Rebase this branch on #8881 2. Go to #4008 3. Hover the first mention 4. Click #3980

SunsetTechuila added 2 commits January 20, 2026 18:51

Load features when navigating between React-based pages

83623b7

replace one-event with p-event

6880958

SunsetTechuila marked this pull request as ready for review January 20, 2026 15:29

fregante reviewed Jan 20, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

Revert "replace one-event with p-event"

383fd6a

This reverts commit 6880958.

SunsetTechuila mentioned this pull request Jan 21, 2026

Listen to multiple events at once fregante/one-event#6

Merged

fregante added the bug label Jan 22, 2026

bump one-event

5f6060f

fregante reviewed Jan 22, 2026

View reviewed changes

source/features/linkify-text.tsx Show resolved Hide resolved

SunsetTechuila commented Jan 22, 2026

View reviewed changes

SunsetTechuila added 3 commits January 26, 2026 19:55

Merge branch 'main' into events

25e58cf

add already linkified error back

39d70a3

unload features on popstate and soft-nav:progress-bar:start

8a551b8

SunsetTechuila changed the title ~~Load features when navigating between React-based pages~~ Fix features loading on soft navigation between React-based pages Jan 27, 2026

SunsetTechuila changed the title ~~Fix features loading on soft navigation between React-based pages~~ Fix feature loading on soft navigation between React-based pages Jan 27, 2026

use soft-nav:start instead of soft-nav:progress-bar:start

64ac445

SunsetTechuila commented Jan 27, 2026

View reviewed changes

fregante reviewed Jan 28, 2026

View reviewed changes

SunsetTechuila marked this pull request as draft February 3, 2026 22:47

SunsetTechuila added a commit that referenced this pull request Feb 3, 2026

handle soft navigation

e2cdd5a

To see the issue or test the fix: 1. Rebase this branch on #8881 2. Go to #4008 3. Hover the first mention 4. Click #3980

SunsetTechuila mentioned this pull request Feb 15, 2026

conversation-activity-filter - Restore feature on PRs #8953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix feature loading on soft navigation between React-based pages#8881

Fix feature loading on soft navigation between React-based pages#8881
SunsetTechuila wants to merge 8 commits intorefined-github:mainfrom
SunsetTechuila:events

SunsetTechuila commented Jan 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

fregante commented Jan 22, 2026

Uh oh!

Uh oh!

SunsetTechuila Jan 22, 2026 •

edited

Loading

Uh oh!

SunsetTechuila Jan 27, 2026

Uh oh!

fregante Jan 28, 2026

Uh oh!

SunsetTechuila Jan 28, 2026 •

edited

Loading

Uh oh!

SunsetTechuila Jan 28, 2026

Uh oh!

SunsetTechuila Jan 28, 2026

Uh oh!

SunsetTechuila Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

		document.addEventListener('soft-nav:start', unloadAll); // Soft navigation
		addEventListener('popstate', unloadAll); // History navigation

	signal.addEventListener('abort', () => {
	descriptionBanner.remove();
	});

	signal.addEventListener('abort', () => {
	disabledBanner.remove();
	});

Uh oh!

Conversation

SunsetTechuila commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test URLs

Screenshot

Uh oh!

Uh oh!

fregante commented Jan 22, 2026

Uh oh!

Uh oh!

SunsetTechuila Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

fregante Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

SunsetTechuila commented Jan 20, 2026 •

edited

Loading

SunsetTechuila Jan 22, 2026 •

edited

Loading

SunsetTechuila Jan 28, 2026 •

edited

Loading