X Tutup
Skip to content

no-self-reference - New feature#8854

Merged
fregante merged 24 commits intorefined-github:mainfrom
Harrish92:feat/underline-pr-self-reference
Jan 24, 2026
Merged

no-self-reference - New feature#8854
fregante merged 24 commits intorefined-github:mainfrom
Harrish92:feat/underline-pr-self-reference

Conversation

@Harrish92
Copy link
Contributor

@Harrish92 Harrish92 commented Jan 7, 2026

@Harrish92 Harrish92 marked this pull request as draft January 7, 2026 22:21
@Harrish92 Harrish92 marked this pull request as ready for review January 8, 2026 22:45
@fregante fregante changed the title underline-pr-self-reference - New Feature no-self-reference - New feature Jan 9, 2026
Co-authored-by: fregante <me@fregante.com>
@Harrish92 Harrish92 marked this pull request as draft January 9, 2026 21:52
@Harrish92 Harrish92 marked this pull request as ready for review January 10, 2026 20:07
@Harrish92 Harrish92 requested a review from fregante January 10, 2026 21:56
Updated the function to disable both link and hovercard attributes for self-references. Adjusted the TODO comment for shorthand property usage in 2027.
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and extended:

Screenshot 4

SunsetTechuila
SunsetTechuila approved these changes Jan 24, 2026
@SunsetTechuila
Copy link
Member

SunsetTechuila commented Jan 24, 2026

this link is clickable -> #8854 if you enter the editing mode and switch to "Preview"

@fregante
Copy link
Member

fregante commented Jan 24, 2026

Damn 😅

I guess the easiest think would be to rebuild the element. @Harrish92 something like

link.replaceWith(
	<span style={{etc}} title="etc">{link.textContent}</span>
);

Edit: this won't work well with links rendered inside bullet points.

@fregante
Copy link
Member

That's weird though, are we doing that? If I disable Refined GitHub and remove the href attribute, it won't open a new tab.

@fregante fregante merged commit 87598c0 into refined-github:main Jan 24, 2026
8 checks passed
@fregante
Copy link
Member

It's good enough for now, it can be updated separately, but honestly it's not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Highlight pr self-closing link

3 participants

X Tutup