Open
Conversation
uglide
force-pushed
the
im/mtls-auth-tests
branch
from
f25fa16 to
2f6b5b8
Compare
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/test/java/redis/clients/jedis/tls/ClientAuthRedisClusterClientIT.java
Show resolved
Hide resolved
uglide
force-pushed
the
im/mtls-auth-tests
branch
from
2f6b5b8 to
46cba55
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Test Results 305 files 305 suites 11m 43s ⏱️ Results for commit 3b7e7f6. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic mTLS tests
Note
Medium Risk
Primarily test and test-environment changes, but it adds new Docker services/endpoints and manipulates JVM truststore properties, which can cause CI flakiness or interfere with other TLS tests if mis-scoped.
Overview
Adds new integration coverage for mutual TLS (client-certificate) authentication across
Jedis,RedisClient, andRedisClusterClient, validatingACL WHOAMIbehavior (CN-based user on Redis 8.6+, otherwisedefault) and basic read/write operations.Introduces a shared
ClientAuthTestBasethat provisions a temporary truststore, locates per-user.p12client keystores, and centralizes version-aware username assertions. Updates test infrastructure (TlsUtil,endpoints.json, anddocker-compose.yml) to provide standalone and 3-node cluster mTLS Redis targets with pre-generated client certs formtls-user1/mtls-user2.Written by Cursor Bugbot for commit 3b7e7f6. This will update automatically on new commits. Configure here.