feat: add testID props to SpeedDial.Action and ListItem.Swipeable#4013
Open
therbta wants to merge 1 commit intoreact-native-elements:nextfrom
Open
feat: add testID props to SpeedDial.Action and ListItem.Swipeable#4013therbta wants to merge 1 commit intoreact-native-elements:nextfrom
therbta wants to merge 1 commit intoreact-native-elements:nextfrom
Conversation
| return ( | ||
| <View style={styles.container}> | ||
| <View style={styles.container} testID={testID}> | ||
| <View style={styles.actions}> |
Contributor
There was a problem hiding this comment.
You can also add the testID to the other sub-components, just like below
testID={testID ? ${testID}-actions : undefined}
Member
|
Hello, thank you for opening this PR. Can you please follow our template for submitting PRs instead of just listing the changes in the area above? This helps the team during review. I have not had the chance to detail review yet but linking a related past PR for reference: #3787 (looks like the test ID was actually set for the component in this one, it is not in this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds
testIDsupport toSpeedDial.ActionandListItem.Swipeableso E2E/UI tests can target these components reliably.Closes #3786
Type of change
How Has This Been Tested?
exampleapp / local project by rendering:SpeedDial.Actionwith atestIDListItem.Swipeablewith atestIDtestIDon the main wrapper${testID}-actionson the swipe actions containerChecklist
Additional context
Related reference PR: #3787