[BottomSheet] add customizable fade animation#3849
Open
onmotion wants to merge 3 commits intoreact-native-elements:nextfrom
Open
[BottomSheet] add customizable fade animation#3849onmotion wants to merge 3 commits intoreact-native-elements:nextfrom
onmotion wants to merge 3 commits intoreact-native-elements:nextfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #3849 +/- ##
==========================================
- Coverage 79.70% 79.64% -0.07%
==========================================
Files 87 87
Lines 1843 1857 +14
Branches 819 828 +9
==========================================
+ Hits 1469 1479 +10
- Misses 369 373 +4
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this still being considered? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current animation for displaying the BottomSheet relies on a modal approach, resulting in the backdrop appearing simultaneously with the content at the bottom of the screen.
Screen.Recording.2023-10-15.at.17.16.53.mov
Fixes # (issue)
Type of change
Added new properties
How Has This Been Tested?
Run example BottomSheet
exampleappChecklist
yarn docs-build-apiAdditional context
Slide
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.33.53.mp4
Fade
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.34.17.mp4
None
Simulator.Screen.Recording.-.iPhone.15.-.2023-10-15.at.16.34.05.mp4