fix(ButtonGroup): add accessibility role to ButtonGroup Text#3822
Open
areyesms wants to merge 1 commit intoreact-native-elements:nextfrom
Open
fix(ButtonGroup): add accessibility role to ButtonGroup Text#3822areyesms wants to merge 1 commit intoreact-native-elements:nextfrom
areyesms wants to merge 1 commit intoreact-native-elements:nextfrom
Conversation
✅ Deploy Preview for react-native-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
areyesms
changed the title
Author
|
@arpitBhalla could you please review this simple change? It is related to #3196. |
areyesms
force-pushed
the
add-accessibility-role-to-buttongroup
branch
from
3262800 to
93baf17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The individual buttons created in ButtonGroup are non-compliant with Accessibility because they lack a Role, so the screen reader only mentions the text but not that the element is actionable. This PR adds the Accessibility Role 'button' since the components created in ButtonGroup are effectively buttons.
Fixes # (issue)
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-api