internxt: implement OpenChunkWriter support#9233
internxt: implement OpenChunkWriter support#9233jzunigax2 wants to merge 1 commit intorclone:masterfrom
Conversation
ncw
left a comment
There was a problem hiding this comment.
I gave this a quick once over - looks great :-)
Can you fix the lint error?
What do you mean by
note I had to exclude OpenChunkWriter from features as we restrict multi part uploads for files smaller than 100MBs, some tests were failling due to this restriction
You've got this in your code which should be all you need. Where are the tests excluded - I don't see that?
ChunkedUpload: fstests.ChunkedUploadConfig{
MinChunkSize: 100 * fs.Mebi,
NeedMultipleChunks: true,
},
…size and concurrency options
I had two failling tests |
Ah, if you do that then you disable the feature and this pr is pointless! It sounds like the first failure is a bug in the tests. The second can be fixed by Skip the test if features.PutStream ==0 Do you want to try to fix the integration tests? |
Oh, then definetely let me remove that line and ensure tests pass |

What is the purpose of this change?
Implement
OpenChunkWriteron the internxt backend to allow for better memory management during file operations.Was the change discussed in an issue or in the forum before?
#9162
Checklist