X Tutup
Skip to content

Removed NSTimerActor. Used CFRunLoopTimerCreateWithHandler instead #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radex merged 1 commit into from
Mar 2, 2016
Merged

Removed NSTimerActor. Used CFRunLoopTimerCreateWithHandler instead #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions Sources/SwiftyTimer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,41 +24,31 @@

import Foundation

private class NSTimerActor {
let block: () -> Void

init(_ block: () -> Void) {
self.block = block
}

@objc func fire() {
block()
}
}

extension NSTimer {
/// Create a timer that will call `block` once after the specified time.
///
/// - Note: The timer won't fire until it's scheduled on the run loop.
/// Use `NSTimer.after` to create and schedule a timer in one step.
/// - Note: The `new` class function is a workaround for a crashing bug when using convenience initializers (rdar://18720947)

public class func new(after interval: NSTimeInterval, _ block: () -> Void) -> NSTimer {
let actor = NSTimerActor(block)
return self.init(timeInterval: interval, target: actor, selector: "fire", userInfo: nil, repeats: false)
return CFRunLoopTimerCreateWithHandler(kCFAllocatorDefault, CFAbsoluteTimeGetCurrent() + interval, 0, 0, 0) { _ in
block()
}
}

/// Create a timer that will call `block` repeatedly in specified time intervals.
///
/// - Note: The timer won't fire until it's scheduled on the run loop.
/// Use `NSTimer.after` to create and schedule a timer in one step.
/// - Note: The `new` class function is a workaround for a crashing bug when using convenience initializers (rdar://18720947)

public class func new(every interval: NSTimeInterval, _ block: () -> Void) -> NSTimer {
let actor = NSTimerActor(block)
return self.init(timeInterval: interval, target: actor, selector: "fire", userInfo: nil, repeats: true)
return CFRunLoopTimerCreateWithHandler(kCFAllocatorDefault, CFAbsoluteTimeGetCurrent() + interval, interval, 0, 0) { _ in
block()
}
}



/// Create and schedule a timer that will call `block` once after the specified time.

public class func after(interval: NSTimeInterval, _ block: () -> Void) -> NSTimer {
Expand Down
X Tutup