fix: correct glob pattern in lint command for consistency#18232
Closed
anilkumarthakur60 wants to merge 5 commits intoquasarframework:devfrom
Closed
fix: correct glob pattern in lint command for consistency#18232anilkumarthakur60 wants to merge 5 commits intoquasarframework:devfrom
anilkumarthakur60 wants to merge 5 commits intoquasarframework:devfrom
Conversation
Member
|
It matches You probably did this to avoid a recent random bug with ESLint due to isaacs/minimatch#284, which is now fixed. So, thanks for the effort, but can't accept this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranchfix: #xxx[,#xxx], where "xxx" is the issue number)Other information:
This PR corrects a small inconsistency in the ESLint glob patterns used across the repository.
Previously, several configurations and documentation examples used the pattern
./src*/**/*.{ts,js,...}, which included a trailing wildcard after the directory name (src*). This is non-standard and could lead to unintended matching of directories (e.g., matching a hypotheticalsrc-backupinstead of justsrc).I have updated these to the standard
./src/**/*.{...}pattern to ensure:srcdirectory.