X Tutup
Skip to content

fix: correct glob pattern in lint command for consistency#18232

Closed
anilkumarthakur60 wants to merge 5 commits intoquasarframework:devfrom
anilkumarthakur60:lint-glob-pattern
Closed

fix: correct glob pattern in lint command for consistency#18232
anilkumarthakur60 wants to merge 5 commits intoquasarframework:devfrom
anilkumarthakur60:lint-glob-pattern

Conversation

@anilkumarthakur60
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated [in the docs](https://github.com/quasarframework/quasar/tree/dev/docs) or explained in the PR's description.

Other information:

This PR corrects a small inconsistency in the ESLint glob patterns used across the repository.

Previously, several configurations and documentation examples used the pattern ./src*/**/*.{ts,js,...}, which included a trailing wildcard after the directory name (src*). This is non-standard and could lead to unintended matching of directories (e.g., matching a hypothetical src-backup instead of just src).

I have updated these to the standard ./src/**/*.{...} pattern to ensure:

  • Consistency: Matches the expected behavior across all Quasar templates and playgrounds.
  • Accuracy: Correctly targets only files within the src directory.
  • Documentation Alignment: Ensures the documentation reflects the actual recommended command for developers.

@anilkumarthakur60 anilkumarthakur60 changed the title Lint glob pattern fix: correct glob pattern in lint command for consistency Feb 25, 2026
@yusufkandemir
Copy link
Member

It matches src-electron, src-pwa, etc. So, it's correct and intended.

You probably did this to avoid a recent random bug with ESLint due to isaacs/minimatch#284, which is now fixed. So, thanks for the effort, but can't accept this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup