updated tests

ej2 · ej2 · commit e7e09f8a9655 · 2015-12-14T14:23:51.000-06:00
diff --git a/README.md b/README.md
@@ -64,6 +64,20 @@ Setup the client connection using the stored `access_token` and the `access_toke
     )
 
 
+If you need to access a minor version (See [Minor versions](https://developer.intuit.com/docs/0100_accounting/0300_developer_guides/minor_versions) for details)
+pass in minorversion when setting up the client:
+
+    QuickBooks(
+        sandbox=True,
+        consumer_key=QUICKBOOKS_CLIENT_KEY,
+        consumer_secret=QUICKBOOKS_CLIENT_SECRET,
+        access_token=access_token,
+        access_token_secret=access_token_secret,
+        company_id=realm_id,
+        minorversion=4
+    )
+
+
 List of objects:
 
     from quickbooks.objects.customer import Customer
@@ -82,11 +96,17 @@ Filtered list of objects with paging:
     customers = Customer.filter(start_position=1, max_results=25, Active=True, FamilyName="Smith")
     
 
+List Filtered by values in list:
+
+    customer_names = ['Customer1', 'Customer2', 'Customer3']
+    customers = Customer.choose(customer_names, field="DisplayName")
+
+
 List with custom Where Clause (do not include the "WHERE"):
         
     customers = Customer.where("Active = True AND CompanyName LIKE 'S%'")
  
- 
+
 List with custom Where Clause with paging:
  
 
diff --git a/quickbooks/utils.py b/quickbooks/utils.py
@@ -17,6 +17,7 @@ def build_where_clause(**kwargs):
 
     return where_clause
 
+
 def build_choose_clause(choices, field):
     where_clause = ""
 
diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py
@@ -21,7 +21,8 @@ def test_client_new(self):
             access_token_secret="access_token_secret",
             company_id="company_id",
             callback_url="callback_url",
-            verbose=True
+            verbose=True,
+            minorversion=4
         )
 
         self.assertEquals(self.qb_client.sandbox, False)
@@ -31,6 +32,7 @@ def test_client_new(self):
         self.assertEquals(self.qb_client.access_token_secret, "access_token_secret")
         self.assertEquals(self.qb_client.company_id, "company_id")
         self.assertEquals(self.qb_client.callback_url, "callback_url")
+        self.assertEquals(self.qb_client.minorversion, 4)
 
     def test_client_updated(self):
         self.qb_client = client.QuickBooks(
diff --git a/tests/unit/test_mixins.py b/tests/unit/test_mixins.py
@@ -37,6 +37,11 @@ def test_query(self, query):
         Department.query(select)
         query.assert_called_once_with(select)
 
+    @patch('quickbooks.mixins.ListMixin.where')
+    def test_choose(self, where):
+        Department.choose(['name1', 'name2'], field="Name")
+        where.assert_called_once_with("Name in ('name1', 'name2')")
+
 
 class ReadMixinTest(unittest.TestCase):
     @patch('quickbooks.mixins.QuickBooks.get_single_object')
diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py
@@ -9,4 +9,14 @@ def setup(self):
     def test_build_where_clause(self):
         where_clause = utils.build_where_clause(field1=1, field2="value2")
 
-        self.assertTrue(where_clause, "WHERE field1 = 1 AND field2 = 'value2")
+        self.assertTrue(where_clause, "WHERE field1 = 1 AND field2 = 'value2")
+
+    def test_build_where_clause_integers(self):
+        where_clause = utils.build_choose_clause(choices=[1, 2], field="field1")
+
+        self.assertTrue(where_clause, "WHERE field1 in (1, 2)")
+
+    def test_build_where_clause_strings(self):
+        where_clause = utils.build_choose_clause(choices=["val1", "val2"], field="field1")
+
+        self.assertTrue(where_clause, "WHERE field1 in ('val1', 'val2')")
