Fix to_ref for taxcode

jpiasetz · jpiasetz · commit ac5a8d366c9b · 2017-06-25T13:28:36.000-04:00
The quickbooks API expects the value to be the ID not the name see: https://developer.intuit.com/docs/api/accounting/taxcode#readataxcode
diff --git a/quickbooks/objects/taxcode.py b/quickbooks/objects/taxcode.py
@@ -65,7 +65,7 @@ def to_ref(self):
         ref = Ref()
 
         ref.type = self.qbo_object_name
-        ref.value = self.Name
-        ref.name = None
+        ref.value = self.Id
+        ref.name = self.Name
 
         return ref
diff --git a/tests/unit/objects/test_taxcode.py b/tests/unit/objects/test_taxcode.py
@@ -20,10 +20,13 @@ def test_valid_object_name(self):
 
     def test_to_ref(self):
         taxcode = TaxCode()
+        taxcode.Id = 2
         taxcode.Name = "test"
 
         ref = taxcode.to_ref()
-        self.assertEquals(ref.value, "test")
+        self.assertEquals(ref.name, "test")
+        self.assertEquals(ref.type, "TaxCode")
+        self.assertEquals(ref.value, 2)
 
 
 class TaxRateDetailTests(unittest.TestCase):
