Some objects need getRequires to be set to False

Gauvain Pocentek · Gauvain Pocentek · commit 05b3abf99b7a · 2017-01-02T11:21:15.000+01:00
diff --git a/gitlab/objects.py b/gitlab/objects.py
@@ -736,6 +736,7 @@ class CurrentUser(GitlabObject):
 class ApplicationSettings(GitlabObject):
     _url = '/application/settings'
     _id_in_update_url = False
+    getRequiresId = False
     optionalUpdateAttrs = ['after_sign_out_path',
                            'container_registry_token_expire_delay',
                            'default_branch_protection',
@@ -794,6 +795,7 @@ class KeyManager(BaseManager):
 class NotificationSettings(GitlabObject):
     _url = '/notification_settings'
     _id_in_update_url = False
+    getRequiresId = False
     optionalUpdateAttrs = ['level',
                            'notification_email',
                            'new_note',
@@ -2022,6 +2024,7 @@ class ProjectService(GitlabObject):
     canCreate = False
     _id_in_update_url = False
     _id_in_delete_url = False
+    getRequiresId = False
     requiredUrlAttrs = ['project_id', 'service_name']
 
     _service_attrs = {
diff --git a/tools/python_test.py b/tools/python_test.py
@@ -290,6 +290,14 @@
 settings = gl.notificationsettings.get()
 assert(settings.level == gitlab.NOTIFICATION_LEVEL_WATCH)
 
+# services
+service = admin_project.services.get(service_name='asana')
+service.active = True
+service.api_key = 'whatever'
+service.save()
+service = admin_project.services.get(service_name='asana')
+assert(service.active == True)
+
 # snippets
 snippets = gl.snippets.list()
 assert(len(snippets) == 0)
