X Tutup
Skip to content

Fixed errors breaking .NET Remoting on method invoke (#276)#637

Merged
den-run-ai merged 1 commit intopythonnet:masterfrom
callumnoble:fix-remoting
Mar 2, 2018
Merged

Fixed errors breaking .NET Remoting on method invoke (#276)#637
den-run-ai merged 1 commit intopythonnet:masterfrom
callumnoble:fix-remoting

Conversation

@callumnoble
Copy link
Copy Markdown
Contributor

@callumnoble callumnoble commented Mar 1, 2018 •
edited
Loading

What does this implement/fix? Explain your changes.

#276

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@callumnoble callumnoble mentioned this pull request Mar 1, 2018
Closed
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2018 •
edited
Loading

Codecov Report

Merging #637 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage    76.9%   76.89%   -0.02%     
==========================================
  Files          64       64              
  Lines        5582     5583       +1     
  Branches      888      889       +1     
==========================================
  Hits         4293     4293              
  Misses       1000     1000              
- Partials      289      290       +1
Flag Coverage Δ
#setup_linux 69.42% <ø> (ø) ⬆️
#setup_windows 76.07% <50%> (-0.02%) ⬇️
Impacted Files Coverage Δ
src/runtime/converter.cs 81.81% <50%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2aa64...f55ee1e. Read the comment docs.

@den-run-ai den-run-ai merged commit 19d854c into pythonnet:master Mar 2, 2018
@den-run-ai den-run-ai mentioned this pull request Mar 2, 2018
Closed
@jcarole
Copy link
Copy Markdown

jcarole commented Oct 19, 2018

Greetings, where can I download a build that contains this fix? Thanks in advance.

@den-run-ai
Copy link
Copy Markdown
Contributor

den-run-ai commented Oct 19, 2018

@jcarole follow instructions in wiki on downloading the wheels from artifacts on Appveyor CI.

@jcarole
Copy link
Copy Markdown

jcarole commented Oct 19, 2018

@denfromufa The previous link I used, https://ci.appveyor.com/project/pythonnet/pythonnet/build/master-1147, no longer has any files. Did this ever get merged in to main? So would I grab the build that supports 3.7?

@den-run-ai
Copy link
Copy Markdown
Contributor

den-run-ai commented Oct 21, 2018

@jcarole, yes this PR is merged into master, see the purple label at the top. The older artifacts get deleted by Appveyor CI automatically.

@jcarole
Copy link
Copy Markdown

jcarole commented Oct 21, 2018

@denfromufa Thank you! This old github-ignorant coder needs to get past the 80s ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor Awaiting requested review from filmor

@tonyroberts tonyroberts Awaiting requested review from tonyroberts

@dmitriyse dmitriyse Awaiting requested review from dmitriyse

@vmuriart vmuriart Awaiting requested review from vmuriart

1 more reviewer

@den-run-ai den-run-ai den-run-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@callumnoble @jcarole @den-run-ai
X Tutup