Fixed errors breaking .NET Remoting on method invoke (#276)#632
Fixed errors breaking .NET Remoting on method invoke (#276)#632den-run-ai wants to merge 2 commits intomasterfrom
Conversation
|
@callumnoble @jcarole this PR for .NET Remoting cannot be merged, because more general solution that would work on .NET Core is necessary. .NET Remoting is deprecated and its API is not available in .NET Core and .NET Standard. |
|
@denfromufa Just to confirm, does this mean that Pythonnet 2.0.0 will be the last version that supports .NET Remoting? |
|
For my application which needs this I'm deploying a wheel I built with 2.3 + this patch. Is working well. I see the fails from the CI build. Would you support an The same define as used here could work? pythonnet/src/runtime/nativecall.cs Line 26 in df2aa64 |
|
@callumnoble that looks reasonable, would you like to make this commit? you can open a new PR if needed. |
|
@denfromufa @callumnoble Exactly. Since .NET Remoting isn't supported by .NET Core (yet, and probably ever), a conditional compilation solution seems ideal. |
|
Will look into doing this sometime in the next few days. |
|
@denfromufa opened new pr for this #637 |
What does this implement/fix? Explain your changes.
#276
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG