match python type T to Nullable<T> in C#

hatami57 · web-flow · commit 9135b9443dcd · 2020-07-30T06:53:29.000+04:30
When a method parameter in C# is defined as Nullable like `int?` and you call it in python by a literal int number, it does not match with `int?` and could not bind the method. At least in .NETStandard2.0. So this update is telling the MethodBinder class that a primitive value (with the type of T) in python can be matched with the corresponding primitive type (T) in C# or Nullable&lt;T&gt; too.
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -523,7 +523,7 @@ static Type TryComputeClrArgumentType(Type parameterType, IntPtr argument, bool
             if (clrtype != null)
             {
                 var typematch = false;
-                if ((parameterType != typeof(object)) && (parameterType != clrtype))
+                if (parameterType != typeof(object) && parameterType != clrtype && Nullable.GetUnderlyingType(parameterType) != clrtype)
                 {
                     IntPtr pytype = Converter.GetPythonTypeByAlias(parameterType);
                     pyoptype = Runtime.PyObject_Type(argument);

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ static Type TryComputeClrArgumentType(Type parameterType, IntPtr argument, bool`
`523`	`523`	`if (clrtype != null)`
`524`	`524`	`{`
`525`	`525`	`var typematch = false;`
`526`		`- if ((parameterType != typeof(object)) && (parameterType != clrtype))`
	`526`	`+ if (parameterType != typeof(object) && parameterType != clrtype && Nullable.GetUnderlyingType(parameterType) != clrtype)`
`527`	`527`	`{`
`528`	`528`	`IntPtr pytype = Converter.GetPythonTypeByAlias(parameterType);`
`529`	`529`	`pyoptype = Runtime.PyObject_Type(argument);`