sect: add Section.orientation setter

Steve Canny · Steve Canny · commit bb3733921599 · 2014-06-21T00:43:15.000-07:00
diff --git a/docx/oxml/section.py b/docx/oxml/section.py
@@ -50,6 +50,11 @@ def orientation(self):
             return WD_ORIENTATION.PORTRAIT
         return pgSz.orient
 
+    @orientation.setter
+    def orientation(self, value):
+        pgSz = self.get_or_add_pgSz()
+        pgSz.orient = value
+
     @property
     def page_height(self):
         """
diff --git a/docx/section.py b/docx/section.py
@@ -23,6 +23,10 @@ def orientation(self):
         """
         return self._sectPr.orientation
 
+    @orientation.setter
+    def orientation(self, value):
+        self._sectPr.orientation = value
+
     @property
     def page_height(self):
         """
diff --git a/features/sct-section-props.feature b/features/sct-section-props.feature
@@ -53,7 +53,6 @@ Feature: Access and change section properties
       | portrait    | WD_ORIENT.PORTRAIT   |
 
 
-  @wip
   Scenario Outline: Set section orientation
     Given a section known to have <initial-orientation> orientation
      When I set the section orientation to <new-orientation>
diff --git a/tests/test_section.py b/tests/test_section.py
@@ -47,6 +47,11 @@ def it_knows_its_page_orientation(self, orientation_get_fixture):
         section, expected_orientation = orientation_get_fixture
         assert section.orientation is expected_orientation
 
+    def it_can_change_its_orientation(self, orientation_set_fixture):
+        section, new_orientation, expected_xml = orientation_set_fixture
+        section.orientation = new_orientation
+        assert section._sectPr.xml == expected_xml
+
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -62,6 +67,21 @@ def orientation_get_fixture(self, request):
         section = Section(sectPr)
         return section, expected_orientation
 
+    @pytest.fixture(params=[
+        (WD_ORIENT.LANDSCAPE, 'landscape'),
+        (WD_ORIENT.PORTRAIT,  None),
+        (None,                None),
+    ])
+    def orientation_set_fixture(self, request):
+        new_orientation, expected_orient_val = request.param
+        # section ----------------------
+        sectPr = self.sectPr_bldr().element
+        section = Section(sectPr)
+        # expected_xml -----------------
+        pgSz_bldr = self.pgSz_bldr(orient=expected_orient_val)
+        expected_xml = self.sectPr_bldr(pgSz_bldr).xml()
+        return section, new_orientation, expected_xml
+
     @pytest.fixture(params=[
         (True,  2880, Inches(2)),
         (True,  None, None),
