sect: add Section.page_height setter

Steve Canny · Steve Canny · commit 81d49bda732a · 2014-06-20T23:36:30.000-07:00
diff --git a/docx/oxml/section.py b/docx/oxml/section.py
@@ -46,6 +46,11 @@ def page_height(self):
             return None
         return pgSz.h
 
+    @page_height.setter
+    def page_height(self, value):
+        pgSz = self.get_or_add_pgSz()
+        pgSz.h = value
+
     @property
     def page_width(self):
         """
diff --git a/docx/section.py b/docx/section.py
@@ -25,6 +25,10 @@ def page_height(self):
         """
         return self._sectPr.page_height
 
+    @page_height.setter
+    def page_height(self, value):
+        self._sectPr.page_height = value
+
     @property
     def page_width(self):
         """
diff --git a/features/sct-section-props.feature b/features/sct-section-props.feature
@@ -35,7 +35,6 @@ Feature: Access and change section properties
       And the reported page height is 11 inches
 
 
-  @wip
   Scenario: Set section page size
     Given a section having known page dimension
      When I set the section page width to 11 inches
diff --git a/tests/test_section.py b/tests/test_section.py
@@ -33,12 +33,16 @@ def it_knows_its_page_width(self, page_width_get_fixture):
     def it_can_change_its_page_width(self, page_width_set_fixture):
         section, new_page_width, expected_xml = page_width_set_fixture
         section.page_width = new_page_width
-        assert section._sectPr.xml == expected_xml
 
     def it_knows_its_page_height(self, page_height_get_fixture):
         section, expected_page_height = page_height_get_fixture
         assert section.page_height == expected_page_height
 
+    def it_can_change_its_page_height(self, page_height_set_fixture):
+        section, new_page_height, expected_xml = page_height_set_fixture
+        section.page_height = new_page_height
+        assert section._sectPr.xml == expected_xml
+
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -53,6 +57,20 @@ def page_height_get_fixture(self, request):
         section = Section(sectPr)
         return section, expected_page_height
 
+    @pytest.fixture(params=[
+        (None,      None),
+        (Inches(2), 2880),
+    ])
+    def page_height_set_fixture(self, request):
+        new_page_height, expected_h_val = request.param
+        # section ----------------------
+        sectPr = self.sectPr_bldr().element
+        section = Section(sectPr)
+        # expected_xml -----------------
+        pgSz_bldr = self.pgSz_bldr(h=expected_h_val)
+        expected_xml = self.sectPr_bldr(pgSz_bldr).xml()
+        return section, new_page_height, expected_xml
+
     @pytest.fixture(params=[
         (True,  1440, Inches(1)),
         (True,  None, None),
