parfmt: add ParagraphFormat.widow_control setter

Steve Canny · Steve Canny · commit 676612d7db41 · 2015-02-08T00:01:45.000-08:00
diff --git a/docx/oxml/text/paragraph.py b/docx/oxml/text/paragraph.py
@@ -366,6 +366,13 @@ def widowControl_val(self):
             return None
         return widowControl.val
 
+    @widowControl_val.setter
+    def widowControl_val(self, value):
+        if value is None:
+            self._remove_widowControl()
+        else:
+            self.get_or_add_widowControl().val = value
+
 
 class CT_Spacing(BaseOxmlElement):
     """
diff --git a/docx/text/paragraph.py b/docx/text/paragraph.py
@@ -376,6 +376,10 @@ def widow_control(self):
             return None
         return pPr.widowControl_val
 
+    @widow_control.setter
+    def widow_control(self, value):
+        self._element.get_or_add_pPr().widowControl_val = value
+
     @staticmethod
     def _line_spacing(spacing_line, spacing_lineRule):
         """
diff --git a/features/txt-parfmt-props.feature b/features/txt-parfmt-props.feature
@@ -148,7 +148,6 @@ Feature: Get or set paragraph formatting properties
       | widow_control     | Off        | False |
 
 
-  @wip
   Scenario Outline: Set On/Off paragraph property
     Given a paragraph format having <prop-name> set <state>
      When I assign <new-value> to paragraph_format.<prop-name>
diff --git a/tests/text/test_paragraph.py b/tests/text/test_paragraph.py
@@ -555,18 +555,23 @@ def on_off_get_fixture(self, request):
         ('w:p', 'keep_together',     True,  'w:p/w:pPr/w:keepLines'),
         ('w:p', 'keep_with_next',    True,  'w:p/w:pPr/w:keepNext'),
         ('w:p', 'page_break_before', True,  'w:p/w:pPr/w:pageBreakBefore'),
+        ('w:p', 'widow_control',     True,  'w:p/w:pPr/w:widowControl'),
         ('w:p/w:pPr/w:keepLines',                 'keep_together',     False,
          'w:p/w:pPr/w:keepLines{w:val=0}'),
         ('w:p/w:pPr/w:keepNext',                  'keep_with_next',    False,
          'w:p/w:pPr/w:keepNext{w:val=0}'),
         ('w:p/w:pPr/w:pageBreakBefore',           'page_break_before', False,
          'w:p/w:pPr/w:pageBreakBefore{w:val=0}'),
+        ('w:p/w:pPr/w:widowControl',              'widow_control',     False,
+         'w:p/w:pPr/w:widowControl{w:val=0}'),
         ('w:p/w:pPr/w:keepLines{w:val=0}',        'keep_together',     None,
          'w:p/w:pPr'),
         ('w:p/w:pPr/w:keepNext{w:val=0}',         'keep_with_next',    None,
          'w:p/w:pPr'),
         ('w:p/w:pPr/w:pageBreakBefore{w:val=0}',  'page_break_before', None,
          'w:p/w:pPr'),
+        ('w:p/w:pPr/w:widowControl{w:val=0}',     'widow_control',     None,
+         'w:p/w:pPr'),
     ])
     def on_off_set_fixture(self, request):
         p_cxml, prop_name, value, expected_cxml = request.param
