fix issue 374 where tweet_volume data was not being populated on Trend instantiation

jeremylow · jeremylow · commit 66766c24670d · 2016-07-29T17:26:30.000-04:00
diff --git a/doc/changelog.rst b/doc/changelog.rst
@@ -1,6 +1,14 @@
 Changelog
 ---------
 
+Version 3.2
+===========
+
+What's Changed
+--------------
+
+* :py:func:`twitter.models.Trend`'s `volume` attribute has been renamed `tweet_volume` in line with Twitter's naming convention. This change should allow users to access the number of tweets being tweeted for a given Trend.
+
 Version 3.1
 ==========
 
diff --git a/testdata/models/models_trend.json b/testdata/models/models_trend.json
@@ -1 +1 @@
-{"name":"#ChangeAConsonantSpoilAMovie","url":"http:\\/\\/twitter.com\\/search?q=%23ChangeAConsonantSpoilAMovie","promoted_content":null,"query":"%23ChangeAConsonantSpoilAMovie","tweet_volume":null}
+{"name":"#ChangeAConsonantSpoilAMovie","url":"http:\\/\\/twitter.com\\/search?q=%23ChangeAConsonantSpoilAMovie","promoted_content":null,"query":"%23ChangeAConsonantSpoilAMovie","tweet_volume":104403}
diff --git a/tests/test_models.py b/tests/test_models.py
@@ -116,6 +116,7 @@ def test_trend(self):
             self.fail(e)
         self.assertTrue(trend.AsJsonString())
         self.assertTrue(trend.AsDict())
+        self.assertEqual(trend.tweet_volume, 104403)
 
     def test_url(self):
         url = twitter.Url.NewFromJsonDict(self.URL_SAMPLE_JSON)
diff --git a/twitter/models.py b/twitter/models.py
@@ -208,7 +208,7 @@ def __init__(self, **kwargs):
             'query': None,
             'timestamp': None,
             'url': None,
-            'volume': None,
+            'tweet_volume': None,
         }
 
         for (param, default) in self.param_defaults.items():

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"name":"#ChangeAConsonantSpoilAMovie","url":"http:\\/\\/twitter.com\\/search?q=%23ChangeAConsonantSpoilAMovie","promoted_content":null,"query":"%23ChangeAConsonantSpoilAMovie","tweet_volume":null}`
	`1`	`+{"name":"#ChangeAConsonantSpoilAMovie","url":"http:\\/\\/twitter.com\\/search?q=%23ChangeAConsonantSpoilAMovie","promoted_content":null,"query":"%23ChangeAConsonantSpoilAMovie","tweet_volume":104403}`
Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ def __init__(self, **kwargs):`
`208`	`208`	`'query': None,`
`209`	`209`	`'timestamp': None,`
`210`	`210`	`'url': None,`
`211`		`- 'volume': None,`
	`211`	`+ 'tweet_volume': None,`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`for (param, default) in self.param_defaults.items():`