Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
==========================================
+ Coverage 91.2% 91.27% +0.07%
==========================================
Files 101 101
Lines 4023 4023
Branches 614 614
==========================================
+ Hits 3669 3672 +3
+ Misses 209 208 -1
+ Partials 145 143 -2
Continue to review full report at Codecov.
|
Codeclimate's defaults are pretty strict. Our complexity is High for objects and bot methods so I decreased the RADON-setting to be a bit more forgiving. Secondly I removed the warning for `similar` code leaving only `duplicate` code.
Eldinnie
force-pushed
the
codeclimate.yml
branch
from
ef4a895 to
867ed05
Compare
jsmnbom
approved these changes
Sep 16, 2017
Member
jsmnbom
left a comment
jsmnbom
left a comment
There was a problem hiding this comment.
Looks good, it was a bit too strict before :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codeclimate's defaults are pretty strict. Our complexity is High for objects and bot methods so I decreased the RADON-setting to be a bit more forgiving.
Secondly I removed the warning for
similarcode leaving onlyduplicatecode.