X Tutup
Skip to content

add utils.helpers to docs#828

Merged
Eldinnie merged 1 commit intomasterfrom
utils-doc
Sep 25, 2017
Merged

add utils.helpers to docs#828
Eldinnie merged 1 commit intomasterfrom
utils-doc

Conversation

@Eldinnie
Copy link
Copy Markdown
Member

I noticed the utils.helpers module was not added to the docs.
Since it contains some handy helper methods I thought it would be good to be able to link to them.

Copy link
Copy Markdown
Member

@jsmnbom jsmnbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :D
Maybe merge from master after #823 is merged so the CI can succeed.

@Eldinnie
Copy link
Copy Markdown
Member Author

Actually I should've marked as ci skip. Nothing changed in code

@jsmnbom
Copy link
Copy Markdown
Member

jsmnbom commented Sep 13, 2017

Yes, just sad to merge "All checks have failed" PRs xD Not that it really matters

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 14, 2017

Codecov Report

Merging #828 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #828     +/-   ##
=========================================
- Coverage   91.77%   91.27%   -0.5%     
=========================================
  Files         101      101             
  Lines        4023     4023             
  Branches      614      614             
=========================================
- Hits         3692     3672     -20     
- Misses        191      208     +17     
- Partials      140      143      +3
Flag Coverage Δ
#Appveyor 86.35% <ø> (ø) ⬆️
#Travis 90.9% <ø> (-0.5%) ⬇️
Impacted Files Coverage Δ
telegram/error.py 86.48% <0%> (-5.41%) ⬇️
telegram/utils/request.py 63.7% <0%> (-4.04%) ⬇️
telegram/ext/updater.py 74.01% <0%> (-3.44%) ⬇️
telegram/message.py 96.01% <0%> (-0.8%) ⬇️
telegram/bot.py 87.46% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5614af1...85f4b27. Read the comment docs.

@python-telegram-bot python-telegram-bot deleted a comment from codecov bot Sep 14, 2017
@jsmnbom jsmnbom added the 📋 pending-merge work status: pending-merge label Sep 25, 2017
@Eldinnie Eldinnie merged commit 8754980 into master Sep 25, 2017
@Eldinnie Eldinnie deleted the utils-doc branch September 25, 2017 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

📋 pending-merge work status: pending-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup