MessageQueue: fixed args dispatching in decorator#705
Merged
thodnev merged 1 commit intopython-telegram-bot:messagequeue-quickfixfrom Jul 8, 2017
thodnev:messagequeue-quickfix
Merged
MessageQueue: fixed args dispatching in decorator#705thodnev merged 1 commit intopython-telegram-bot:messagequeue-quickfixfrom thodnev:messagequeue-quickfix
thodnev merged 1 commit intopython-telegram-bot:messagequeue-quickfixfrom
thodnev:messagequeue-quickfix
Conversation
Member
Is it not included in this PR? |
Member
Author
|
@jh0ker Example is in link under the image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devil is in detail, it didn't work because I forgot to add self to args tuple during dispatching.
Finally it's alive and breathing. See the screenshot (reply time of messages). I also add a simple example, which demonstrates MessageQueue usage.
Again, for now its only 90% of work done and MQ is already usable. But the next step is its proper native incorporation into Bot class without all these dirty decorator tricks.
Also seems that we need to dedicate at least one wiki page on how MQ works and how to use it.
The next week I plan to dedicate myself working on it.
test_example.py