Merged
Conversation
Cross references method and class signatures with official docs
First errors found by the official test thingy
tsnoam
approved these changes
Jun 20, 2017
Member
tsnoam
left a comment
tsnoam
left a comment
There was a problem hiding this comment.
excellent work. just make sure to merge/rebase with latest master and if travis will still pass we can merge.
So they fit in with the rest better
Bibo-Joshi
added
🔌 enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test which cross references all bot methods and all types/classes with the official bot documentation. For now just checks if we have all methods and classes and whether they have the correct parameters.
Has a few workarounds for deprecation logic and such :/
It emits 105 tests, unfortunately it doesn't increase coverage one bit :( It would be lovely if we could figure out how to make it actually call (or initialize with classes) the method/class so eventual exception logic would be executed, but I wasn't sure how to do something like that.
It would also be nice if we could have it check our docstrings (maybe fuzzily, so they have to partically match like 75% or something?). It could also check that the types match, and whether it's required or not.
Note: PR also includes fixes for two things that didn't match the official docs, so tests actually pass.