Rename shortcut functions to snake_case#661
Rename shortcut functions to snake_case#661jh0ker merged 7 commits intopython-telegram-bot:masterfrom
Conversation
|
I know there are a few other places... maybe if you search for "*args, **kwargs" or something you'll find them.. |
|
Found some more, working on it. |
|
Ok. There is more. Give me one or two days to look through the code, there are some files, I did not look at yet. |
|
Ok, I'm done. I read through all the code and will go to bed now. That should really have been it now. |
|
@saschalalala Good night :) |
|
Okay, some tests fail because the MockBot also has to be reworked a little. However, I reread the contributing doc and set up my environment to run the tests locally before pushing the changes and I receive some other errors like |
|
@saschalalala make sure to read the installation instructions carefully. You did not pull the submodule. Easiest way to fix is running |
|
Okay, thanks. I overlooked that because I only read the contributing guide m( The tests are running fine on my machine now. |
|
@saschalalala thanks for pointing that out, we need to add this change in our contributing guide aswell. |
|
Is there anything I can do regarding the two failed tests or are they related to the test environment and network issues? |
this needs to be fixed, the timed out error is nothing to worry about. |
|
This looks great, thank you for the effort! |
I renamed some functions in message.py to snake case for consistency. Are there any other files that need function renaming?