Add both handlers for queries from new Payment API#630
Merged
jh0ker merged 4 commits intopython-telegram-bot:betafrom May 22, 2017
jeffffc:paymenthandlers
Merged
Add both handlers for queries from new Payment API#630jh0ker merged 4 commits intopython-telegram-bot:betafrom jeffffc:paymenthandlers
jh0ker merged 4 commits intopython-telegram-bot:betafrom
jeffffc:paymenthandlers
Conversation
jh0ker
requested changes
May 22, 2017
Member
jh0ker
left a comment
jh0ker
left a comment
There was a problem hiding this comment.
Looks very good on a first glance, just two minor comments for now
telegram/precheckoutquery.py
Outdated
| return data | ||
|
|
||
| def answer(self, *args, **kwargs): | ||
| """Shortcut for ``bot.answerPreCheckoutQuery(update.callback_query.id, *args, **kwargs)``""" |
Member
There was a problem hiding this comment.
The docstring has callback_query instead of pre_checkout_query
telegram/shippingquery.py
Outdated
| return data | ||
|
|
||
| def answer(self, *args, **kwargs): | ||
| """Shortcut for ``bot.answerShippingQuery(update.callback_query.id, *args, **kwargs)``""" |
jsmnbom
requested changes
May 22, 2017
telegram/update.py
Outdated
| user = self.shipping_query.from_user | ||
|
|
||
| elif self.pre_checkout_query: | ||
| user = self.pre_checkout_query |
Member
|
Thanks :) Can you open the PR again, to the master branch? |
This was referenced May 22, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PreCheckoutQueryHandler and ShippingQueryHandler