Implemented undocumented 'deleteMessage' method#602
Merged
jh0ker merged 5 commits intopython-telegram-bot:masterfrom May 12, 2017
evgfilim1:delete-message
Merged
Implemented undocumented 'deleteMessage' method#602jh0ker merged 5 commits intopython-telegram-bot:masterfrom evgfilim1:delete-message
jh0ker merged 5 commits intopython-telegram-bot:masterfrom
evgfilim1:delete-message
Conversation
Now tests can run on Python 2.7 without raising 'AttributeError'
Member
|
Looks good, however please add a warning to the docstring describing that it's undocumented and not guaranteed to work. |
Added a warning to the docstring describing that this method is undocumented and not guaranteed to work
Contributor
Author
|
@bomjacob Done |
Member
|
Thanks a lot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
Bot.delete_messageandMessage.deleteAdded tests for methods above