Add ability for custom filename in send methods and InputFile#57
Merged
leandrotoledo merged 6 commits intopython-telegram-bot:testingfrom Sep 8, 2015
ergoz:testing
Merged
Add ability for custom filename in send methods and InputFile#57leandrotoledo merged 6 commits intopython-telegram-bot:testingfrom ergoz:testing
leandrotoledo merged 6 commits intopython-telegram-bot:testingfrom
ergoz:testing
Conversation
For commands that uses InputFile class
For commands that uses InputFile class
telegram/inputfile.py
Outdated
Member
There was a problem hiding this comment.
and self.data['filename'] is redundant of if 'filename' in self.data, so you can keep only the first part.
Member
|
Nicely done, please just make the minor changes I've noted and we'll be good to merge in. |
leandrotoledo
added a commit
that referenced
this pull request
Sep 8, 2015
Add ability for custom filename in send methods and InputFile
Member
|
Yay! Thanks. I'll take care of these Travis tests errors, it wasn't your PR but some TelegramError parse issues. |
Contributor
Author
|
Telegram api server 502 bad gateway :) How to run travis building again? |
Member
|
That's a good question! haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods sendAudio, sendVideo, sendVoice, sendDocument and other that uses real files updated to add ability to set custom filename that will show in telegram client.