Changed promises to handle exceptions#529
Merged
jh0ker merged 1 commit intopython-telegram-bot:masterfrom Feb 27, 2017
thodnev:promises-with-exceptions
Merged
Changed promises to handle exceptions#529jh0ker merged 1 commit intopython-telegram-bot:masterfrom thodnev:promises-with-exceptions
jh0ker merged 1 commit intopython-telegram-bot:masterfrom
thodnev:promises-with-exceptions
Conversation
jh0ker
added a commit
that referenced
this pull request
Feb 27, 2017
jh0ker
added a commit
that referenced
this pull request
Feb 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
Promisesaves exception in instance if caught, and reraises it whenPromise's result is get, instead of rerasing it during run (possibly even in unknown thread)__call__method added toPromise, so now promises look more like normal callables and are more convenient to use (old run method saved for backwards-compat.)Promises handling changed in
Dispatcher, so that now dispatcher just runs promises and doesn't need to deal with any possible exceptions as it's work of Promise. Earlier it just logged that something went wrong in case of exceptions.Promise handling logic is changed in
ConversationHandler, assuming that changed promise may now raise exceptions on res, in that case logger is used for handlingThese changes are 1st step on the way to introducing
MessageQueue. Had a conversation with @jh0ker about this change proposalTest results are added below.
test_results.txt