Prevented modifications to the request object's original data#454
Merged
tsnoam merged 6 commits intopython-telegram-bot:masterfrom Dec 19, 2016
Merged
Conversation
Contributor
Author
|
Looks like the tests are failing because too many requests were sent, like in #459. |
no-messing-with-request # Conflicts: # telegram/utils/request.py
Member
|
@HakimusGIT
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
de_json()methods of some subclasses ofTelegramObjectmake modifications to the data of the request object. Usually, this shouldn't be a problem, but it might be one if other parts of the code try to read the data and expect something else to be there. By callingTelegramObject'sde_json()method, which makes a copy of the data that can be worked with, this problem should be solved.See #357 for an issue concerning this.