X Tutup
Skip to content

Use explicit kwargs#442

Merged
jsmnbom merged 5 commits intomasterfrom
explicit-kwargs
Oct 19, 2016
Merged

Use explicit kwargs#442
jsmnbom merged 5 commits intomasterfrom
explicit-kwargs

Conversation

@jsmnbom
Copy link
Copy Markdown
Member

@jsmnbom jsmnbom commented Oct 16, 2016

Closes #424
This should improve IDEs' autocompletion since most just look at the signature of the method and not the whole docstring (especially not the docstring of the containing class).
**kwargs is kept for future compatibility if (when) telegram changes their API.

This improves support for many IDEs' autocompletion.
While not stickily necessary for most classes (since user isn't directly creating them) it still unifies our approach.
However for some like ReplyKeyboardHide where users are making the classes themselves it should improve IDE autocomplete support.
@tsnoam tsnoam added the 📋 pending-review work status: pending-review label Oct 16, 2016
@tsnoam tsnoam self-assigned this Oct 16, 2016
@jsmnbom jsmnbom merged commit 225bc24 into master Oct 19, 2016
@jsmnbom jsmnbom added enhancement ⚙️ documentation affected functionality: documentation and removed 📋 pending-review work status: pending-review labels Oct 19, 2016
@jsmnbom jsmnbom deleted the explicit-kwargs branch May 20, 2017 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ documentation affected functionality: documentation 🔌 enhancement pr description: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use explicit keyword arguments

3 participants

X Tutup