Add api changes as of october by jsmnbom · Pull Request #431 · python-telegram-bot/python-telegram-bot

jsmnbom · 2016-10-03T13:26:48Z

Add changes as of October 3, 2016.
Mostly games: https://core.telegram.org/bots/api#games
Other changes: https://core.telegram.org/bots/api#recent-changes

Or at least the methods/classes for sending.

Still needs tests though

Missing docstrings for now though, wanna add everything first

Also chat_instance in CallbackQuery which will break a lot of tests probably

N.B. test_send_video_mp4_file_url() is still failing, probably because of telegram servers bug. Will contact telegram bot support about that.

Also, small fix to the description text of ChatMigrated

- fix copy/paste errors - return Message object

* bot.py fix copy paste error in url * callbackquery.py make data field optional * message.py introduce optional game field

small fix for game related parts

Data is an optional kwargs in CallbackQuery according to Telegram

Still need setGameScore (I'm thinking we can set it to the ever increasing envvar 'TRAVIS_BUILD_NUMBER') and getGameHighScores. The tests currently don't work... Since I don't really understand how PhotoSize works... Please halp :P

) * fixes broken test with PhotoSize, Game and Animation However: testSendGame and test_set_game_score both produces *BadRequest: u'Wrong file identifier/HTTP URL specified'*. * fixes test_set_game_score * adds to_dict method to Game to prevent extra collection type checks in base.TelegramObject

Needs proper animation file_id and size. Also assertEqual can't test if two objects have the same data, so we just check the file_id instead.

jh0ker · 2016-10-15T21:06:30Z

telegram/bot.py

+    @message
+    def sendGame(self,
+                 chat_id,
+                 game_short_name,


According to https://core.telegram.org/bots/api#sendgame the kwargs should be different

jh0ker · 2016-10-15T21:09:43Z

telegram/bot.py

+            data['edit_message'] = edit_message
+
+        result = self._request.post(url, data, timeout=kwargs.get('timeout'))
+        return Message.de_json(result, self)


result could be just True (https://core.telegram.org/bots/api#setgamescore), won't this raise an error?

jh0ker · 2016-10-15T21:14:15Z

telegram/callbackquery.py

        self.message = kwargs.get('message')
+        self.data = kwargs.get('data', '')
        self.inline_message_id = kwargs.get('inline_message_id', '')
+        self.game_short_name = kwargs.get('game_short_name')


Use an empty string as default

jh0ker · 2016-10-15T21:14:49Z

telegram/chat.py

        self.username = kwargs.get('username', '')
        self.first_name = kwargs.get('first_name', '')
        self.last_name = kwargs.get('last_name', '')
+        self.all_members_are_admins = kwargs.get('all_members_are_admins', '')


Should be False as default, not empty string

jh0ker · 2016-10-15T21:20:13Z

telegram/game.py

+        data['text_entities'] = [x.to_dict() for x in self.text_entities]
+
+        return data
+


are these just copy-pasted from telegram.Message?

Yeah, they are. Is there a better way to do it?

@bomjacob
I think what @jh0ker means is that you don't need to manually serialize a list. the base class will do it for you. (and yes, i missed it myself going over the code)

jh0ker · 2016-10-15T21:21:40Z

telegram/gamehighscore.py

+#
+# You should have received a copy of the GNU Lesser Public License
+# along with this program.  If not, see [http://www.gnu.org/licenses/].
+"""This module contains a object that represents a Telegram GameHighScore."""


Are you sure... an sounds wrong to me here.. T is a consonant sound, and so is G for that matter so I think it should be a.
I could be wrong though...

Not meaning to meddle :), but he's most likely talking about "a object", not "a Telegram".

Ah of cause, sorry, I derped. Will fix shortly :) Thanks :D
EDIT: It seems however that we use "a object" litterally everywhere in the library... @jh0ker, Should I fix this everywhere, leave it for now, or just fix this particular instance?

jh0ker · 2016-10-15T21:24:10Z

telegram/game.py

+                 title,
+                 description,
+                 photo,
+                 text=None,


empty string?

jh0ker · 2016-10-15T21:30:21Z

telegram/webhookinfo.py

+        self.has_custom_certificate = has_custom_certificate
+        self.pending_update_count = pending_update_count
+        self.last_error_date = kwargs.get('last_error_date')
+        self.last_error_message = kwargs.get('last_error_message')


empty string

# Conflicts: # telegram/bot.py # telegram/callbackquery.py # telegram/chat.py # telegram/ext/messagehandler.py # telegram/inlinekeyboardbutton.py # telegram/inlinequeryresultcachedaudio.py # telegram/message.py # tests/test_filters.py

jsmnbom added 4 commits October 3, 2016 14:52

Add switch_inline_query_current_chat

c3e07b1

Add caption fields to voice and audio

f7ede4b

Or at least the methods/classes for sending.

Add WebhookInfo and getWebhookInfo

868d921

Still needs tests though

Add url to answerCallbackQuery

34c62a6

jsmnbom mentioned this pull request Oct 3, 2016

Add October 3 changes #429

Closed

8 tasks

jsmnbom added the ⚙️ bot-api affected functionality: bot-api label Oct 3, 2016

tsnoam and others added 24 commits October 3, 2016 20:43

cosmetic fixes and documentation for getWebhookInfo

e8a34d8

Add all new Game related classes

9e9309e

Missing docstrings for now though, wanna add everything first

Merge remote-tracking branch 'origin/october3' into october3

f3b8a3a

fix syntax error by some weird char

8737b5d

Fix import order

1f67623

Add send_game

151a441

Add the rest of game_ methods to bot.

358dd79

Add InlineQueryResultGame

ae17eb3

Add game parameters in various places

551f6c5

Also chat_instance in CallbackQuery which will break a lot of tests probably

Make tests actually run at all

5e2d96b

Fix tests for Inline Voice Queries

8234321

Fix regexGroupHandlerCallbackQuery test

c2b8c4b

Allow http url as a file_id

3c88965

N.B. test_send_video_mp4_file_url() is still failing, probably because of telegram servers bug. Will contact telegram bot support about that.

inputfile: define the file types as constant and use iterator

3a0f219

InputFile: use self instead of explicit class name

4180c06

answerCallbackQuery: fix copy/paste: show_alert -> url

9b74625

small documentation fixes

7cf5009

New exception: RetryAfter

2463b4b

Also, small fix to the description text of ChatMigrated

sendGame(): mall fixes

d5567cd

callbackgame: small documentation fix

34748ec

setGameScore: fixes

3619291

- fix copy/paste errors - return Message object

getGameHighScores(): added documentation + fixed copy-paste errors

d70fc48

GameHighScore: added attributes documentation

fab97df

Animation: use explicit keyword args + added documentation

837e9d2

tsnoam and others added 14 commits October 6, 2016 00:11

add unitest for getWebhookInfo

bfb4c63

small fix for game related parts

8cab735

* bot.py fix copy paste error in url * callbackquery.py make data field optional * message.py introduce optional game field

add myself to AUTHORS.rst

e672625

Merge pull request #433 from PH89/october3

67b98e3

small fix for game related parts

Fix tests

ade8977

Data is an optional kwargs in CallbackQuery according to Telegram

Add game filter

b7c7612

Add tests for Game, Animation and sendGame.

d1ddfad

Still need setGameScore (I'm thinking we can set it to the ever increasing envvar 'TRAVIS_BUILD_NUMBER') and getGameHighScores. The tests currently don't work... Since I don't really understand how PhotoSize works... Please halp :P

Add test for set_game_score

7ad92dc

Update test cases

04feeef

Needs proper animation file_id and size. Also assertEqual can't test if two objects have the same data, so we just check the file_id instead.

yapf fixes

32a7872

yapf: use our own mirror of yapf & update to version 0.12.2

d07a1c3

upgrade yapf to ver 0.12.2

5b8efe0

Improve unitests coverage

53a574b

jsmnbom added the 📋 pending-review work status: pending-review label Oct 14, 2016

Only build master branch and PRs on travis. Yapf only on py3.5.

de96cc8

jsmnbom mentioned this pull request Oct 15, 2016

Add switch_inline_query_current_chat #440

Closed

Respect RetryAfter with polling Updater

a68cf8d

jh0ker requested changes Oct 15, 2016

View reviewed changes

jsmnbom and others added 5 commits October 16, 2016 12:41

set_game_score might return True

305ff93

send_game has differnt kwargs.

3754cda

Better kwargs defaults.

62dd3a3

Update support date in readme.

7fafaa1

Fix grammer: 'a object' -> 'an object'

78088f4

jh0ker approved these changes Oct 18, 2016

View reviewed changes

Merge branch 'master' into october3

960862c

# Conflicts: # telegram/bot.py # telegram/callbackquery.py # telegram/chat.py # telegram/ext/messagehandler.py # telegram/inlinekeyboardbutton.py # telegram/inlinequeryresultcachedaudio.py # telegram/message.py # tests/test_filters.py

jsmnbom merged commit 61fe438 into master Oct 19, 2016

jsmnbom removed the 📋 pending-review work status: pending-review label Oct 19, 2016

jsmnbom deleted the october3 branch May 20, 2017 13:50

github-actions bot locked and limited conversation to collaborators Aug 23, 2020

		data['text_entities'] = [x.to_dict() for x in self.text_entities]

		return data

Conversation

jsmnbom commented Oct 3, 2016 • edited by tsnoam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsmnbom Oct 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jsmnbom commented Oct 3, 2016 •

edited by tsnoam

Loading

jsmnbom Oct 16, 2016 •

edited

Loading