join() threads for a cleaner stop procedure#177
Merged
tsnoam merged 5 commits intopython-telegram-bot:masterfrom Feb 19, 2016
Merged
join() threads for a cleaner stop procedure#177tsnoam merged 5 commits intopython-telegram-bot:masterfrom
tsnoam merged 5 commits intopython-telegram-bot:masterfrom
Conversation
| self.send_error(e.http_code) | ||
| self.end_headers() | ||
|
|
||
| def _validate_post(self): |
Member
There was a problem hiding this comment.
I may be missing something, but this is not called, is it?
Member
Author
There was a problem hiding this comment.
your eyes are working properly :)
i forgot to call self._validate_post() instead of the if statement in do_POST()
tsnoam
force-pushed
the
master
branch
2 times, most recently
from
13da999 to
43dc151
Compare
telegram/dispatcher.py
Outdated
| """ | ||
| global running_async, async_lock | ||
| thread = Thread(target=pooled, args=pargs, kwargs=kwargs) | ||
| uu = str(uuid.uuid1()) |
Member
There was a problem hiding this comment.
Do we still need this, or could we just go with the default thread name?
- new book keeping of dispatcher's async threads so they can be joined when stopping - updater, webhook & dispatcher threads are now kept on Updater.__threads so they can be joined at the end refs python-telegram-bot#175
tsnoam
added a commit
that referenced
this pull request
Feb 19, 2016
join() threads for a cleaner stop procedure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus some minor fixes / code cleanups