Conversation
telegram/inputfile.py
Outdated
Member
There was a problem hiding this comment.
os.path.basename also works with URIs, like
basename('http://abc.com/test.mp3')
=> 'test.mp3'
Member
|
Did some minor comments, but code looks good. |
Member
Author
|
@leandrotoledo Nice! I'll get on that :) |
Member
|
Adding some tests for send(Audio,Video,Voice) by URL, although, tests are failing because the file_size deosn't match (from client perspective I receive the file, but it's unplayable or an empty image). Needs further investigation. |
Member
|
@jh0ker LGTM, good to be merged/released. |
jh0ker
added a commit
that referenced
this pull request
Jan 13, 2016
enable sending by URL for all sendX methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.